Repository navigation
Adds support for what4 1.1 - #218
Closed
benjaminselfridge wants to merge 1 commit into
Closed
benjaminselfridge wants to merge 1 commit into
benjaminselfridge wants to merge 1 commit into
Conversation
This commit makes the changes required to the what4 translation for what4-1.1 compatibility. There were two significant changes that affected Copilot.Theorem.What4. The first was the type of ExprSymFn changed trivially; it no longer requires (Expr t) as an argument. The second was that concrete floating point operations are now implemented, and the libBF library is used for that, so several types changed from raw bitvectors to libBF floats.
Member
|
Thanks Ben, this really helps a lot! |
Contributor
Author
|
@fdedden You're welcome! I really appreciate that feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the changes required to the what4 translation for what4-1.1
compatibility.
There were two significant changes that affected Copilot.Theorem.What4. The
first was the type of ExprSymFn changed trivially; it no longer requires (Expr
t) as an argument. The second was that concrete floating point operations are
now implemented, and the libBF library is used for that, so several types
changed from raw bitvectors to libBF floats.